Simple patches are good patches. Every fix should be in a separate patch.

Patches should be tested for regressions against wine dlls/d3d9/tests/ . In case you get segfault without patch, feel free comment parts which are not related to your patch.

You can also ask for Tested-by on IRC and let someone recheck with his HW your patch. It's good to know it also works for others.

Before you send a pull-request on github, it's required to verify all your games and simple demos work.

A commit must include a simple description, optionally what it fixed for you and your “Signed-off-by” with full name and valid email.

For getting the patch into Mesa, you need at least two Reviewed-by or ACKed by. Minimally one R-b has to come from David Heidelberg (okias), Axel Davy (mannerov) or Marek Olšák (mareko).

Cc is for including commit also in stable release. It should be used when no major rework of Nine code is done.

Example of git log output:

commit f5d27c45a858db2be60051a0970b054c7ae9182f
Author: David Heidelberg <>
Date:   Tue Nov 18 10:10:55 2014 +0100

    st/nine: fix query counter
    Fixed wine-1.7.30 test at line 623 and game XY loading
    Tested on Radeon HD 6550.
    Cc: "10.4" <>
    Signed-off-by: David Heidelberg <>