Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision 		Previous revision
d3d9_patch [2014/11/19 18:12]
okias 		d3d9_patch [2014/12/07 21:51]
okias Tested-by
Line 1: Line 1:
-**Simple patch is good patch.** Every fix in separate patch.+**Simple patches are good patches.** Every fix should be in a separate patch.
  
-Before you'll send pull-request on github, is required to verify all your games and simple demos works.+Patches **should be tested** for regressions against wine dlls/d3d9/tests/ . In case you get segfault without patch, feel free comment parts which are not related to your patch.
  
-Correct commit must include simple description, optionally what it fix for you and your "**Signed-off-by**" with full name and valid email.+You can also ask for **Tested-by** on IRC and let someone recheck with his HW your patch. It's good to know it also works for others.
  
-For getting patch in Mesa, you need at least two Reviewed-by or ACKed by. Minimally one R-b has to come from David Heidelberg (okias), Axel Davy (mannerov) or Marek Olšák (mareko).+Before you send a pull-request on github, it's required to verify all your games and simple demos work.
  
-Example of git log output:+A commit must include a simple description, optionally what it fixed for you and your "**Signed-off-by**" with full name and valid email.
  
 +For getting the patch into Mesa, you need at least two Reviewed-by or ACKed by. Minimally one R-b has to come from David Heidelberg (okias), Axel Davy (mannerov) or Marek Olšák (mareko).
 +
 +Cc is for including commit also in stable release. It should be used when no major rework of Nine code is done.
 +
 +Example of git log output:
 +<code>
 commit f5d27c45a858db2be60051a0970b054c7ae9182f commit f5d27c45a858db2be60051a0970b054c7ae9182f
 Author: David Heidelberg <david@ixit.cz> Author: David Heidelberg <david@ixit.cz>
 Date:   Tue Nov 18 10:10:55 2014 +0100 Date:   Tue Nov 18 10:10:55 2014 +0100
  
-    nine: fix query counter+    st/nine: fix query counter
          
-    Fixes "Error : CONST[20]: Undeclared source register" when running +    Fixed wine-1.7.30 test at line 623 and game XY loading 
-    dx9_alpha_blending_material. Also artifacts on ilo.+    Tested on Radeon HD 6550.
          
 +    Cc: "10.4" <mesa-stable@lists.freedesktop.org>
     Signed-off-by: David Heidelberg <david@ixit.cz>     Signed-off-by: David Heidelberg <david@ixit.cz>
  
-```+</code>