Differences
This shows you the differences between two versions of the page.
| Both sides previous revision Previous revision Next revision | Previous revision | ||
|
d3d9_patch [2014/11/19 23:45] sarnex |
d3d9_patch [2014/12/07 21:51] okias Tested-by |
||
|---|---|---|---|
| Line 1: | Line 1: | ||
| **Simple patches are good patches.** Every fix should be in a separate patch. | **Simple patches are good patches.** Every fix should be in a separate patch. | ||
| + | |||
| + | Patches **should be tested** for regressions against wine dlls/ | ||
| + | |||
| + | You can also ask for **Tested-by** on IRC and let someone recheck with his HW your patch. It's good to know it also works for others. | ||
| Before you send a pull-request on github, it's required to verify all your games and simple demos work. | Before you send a pull-request on github, it's required to verify all your games and simple demos work. | ||
| Line 6: | Line 10: | ||
| For getting the patch into Mesa, you need at least two Reviewed-by or ACKed by. Minimally one R-b has to come from David Heidelberg (okias), Axel Davy (mannerov) or Marek Olšák (mareko). | For getting the patch into Mesa, you need at least two Reviewed-by or ACKed by. Minimally one R-b has to come from David Heidelberg (okias), Axel Davy (mannerov) or Marek Olšák (mareko). | ||
| + | |||
| + | Cc is for including commit also in stable release. It should be used when no major rework of Nine code is done. | ||
| Example of git log output: | Example of git log output: | ||
| Line 13: | Line 19: | ||
| Date: Tue Nov 18 10:10:55 2014 +0100 | Date: Tue Nov 18 10:10:55 2014 +0100 | ||
| - | nine: fix query counter | + | |
| | | ||
| Fixed wine-1.7.30 test at line 623 and game XY loading | Fixed wine-1.7.30 test at line 623 and game XY loading | ||
| Tested on Radeon HD 6550. | Tested on Radeon HD 6550. | ||
| | | ||
| + | Cc: " | ||
| Signed-off-by: | Signed-off-by: | ||
| </ | </ | ||